Wait for the web-fonts to be load before calling checkLayout script. #22332
+53
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
mrego,
plinss,
rachelandrew,
svillar and
tabatkins
mrego
approved these changes
Mar 20, 2020
|
|
||
| grid.style.height = "300px"; | ||
|
|
||
| item1.setAttribute("data-offset-y", "35"); | ||
| item2.setAttribute("data-offset-y", "160"); | ||
| checkLayout('#grid'); | ||
|
|
||
| checkLayout('#grid', true); |
There was a problem hiding this comment.
Nit: You don't need to pass "true" on the last call, but it's fine if you want to be explicit here. Feel free to keep it or remove it as you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should ensure that the Ahem font is loaded before executing the test asserts.
Additionally, this PR uses the cehckLayout api to avoid calliing done() in the intermediate steps.